New Query Pipeline #14455
Merged
New Query Pipeline #14455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smitpatel
force-pushed
the
smit/query
branch
3 times, most recently
from
c030039
to
b416870
Compare
smitpatel
force-pushed
the
smit/query
branch
2 times, most recently
from
19bf245
to
dcdeadf
Compare
smitpatel
force-pushed
the
smit/query
branch
3 times, most recently
from
932d624
to
1efef34
Compare
|
#14971 cross-linking so I can see over there easily when this PR is merged. |
smitpatel
force-pushed
the
smit/query
branch
3 times, most recently
from
4067e2e
to
cabd484
Compare
Closed
smitpatel
force-pushed
the
smit/query
branch
2 times, most recently
from
1dba152
to
9aeb6b3
Compare
maumar
reviewed
Apr 30, 2019
|
This is ready for review. |
maumar
reviewed
May 2, 2019
src/EFCore.Relational/Query/PipeLine/SqlExpressions/TableExpression.cs
Outdated
Show resolved
Hide resolved
| var isLeftNull = sqlBinary.Left is SqlConstantExpression leftConstant && leftConstant.Value == null; | ||
| var isRightNull = sqlBinary.Right is SqlConstantExpression rightConstant && rightConstant.Value == null; | ||
|
|
||
| if (isLeftNull || isRightNull) |
There was a problem hiding this comment.
this wont for for case where both values are null - those would be optimized at some point, so I guess its fine to leave this as is
| Visit( | ||
| hasNullValue | ||
| ? (Expression)new SqlUnaryExpression( | ||
| ExpressionType.Equal, inExpression.Item, inExpression.Type, inExpression.TypeMapping) |
There was a problem hiding this comment.
creative re-use of existing assets ;)
src/EFCore.Relational/Query/PipeLine/RelationalQueryableMethodTranslatingExpressionVisitor.cs
Show resolved
Hide resolved
src/EFCore.Relational/Query/PipeLine/RelationalQueryableMethodTranslatingExpressionVisitor.cs
Outdated
Show resolved
Hide resolved
src/EFCore.Relational/Query/PipeLine/RelationalQueryableMethodTranslatingExpressionVisitor.cs
Show resolved
Hide resolved
|
Addressed feedback and disabled all failing tests. Build should be passing. |
What works: Non-collection queries Sync/Async InMemory/Sqlite/SqlServer Method/Member translators Spatial What does not work: Cosmos provider - Tests are skipped in normal run so will fix later Collection queries - Includes/Correlated Subquery is not implemented yet Subquery lifting - Was dependent on nav rewrite A lot of small optimizations in expression tree/generated Sql Null semantics TPH Broader list at #14630 Notes: Old files are not deleted yet. (keeping them for reference for now) Still target NS2.0 Class names/namespaces are not final. Doc comments missing
|
|
maumar
approved these changes
May 2, 2019
ghost
deleted the
AndriySvyryd
reviewed
May 3, 2019
| using System.Linq.Expressions; | ||
| using Microsoft.EntityFrameworkCore.Internal; | ||
|
|
||
| namespace Microsoft.EntityFrameworkCore.Query.Pipeline |
There was a problem hiding this comment.
Why the folder is PipeLine and not Pipeline? 😭
There was a problem hiding this comment.
Rename went bad. I will correct it to please unicorns.
There was a problem hiding this comment.
Yes this was a major issue hurting my eyes as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What works:
Non-collection queries
Sync/Async
InMemory/Sqlite/SqlServer
Method/Member translators
Spatial
What does not work:
Cosmos provider - Tests are skipped in normal run so will fix later
Collection queries - Includes/Correlated Subquery is not implemented yet
Subquery lifting - Was dependent on nav rewrite
A lot of small optimizations in expression tree/generated Sql
Null semantics
TPH
Broader list at #14630
Notes:
Old files are not deleted yet. (keeping them for reference for now)
Still target NS2.0
Class names/namespaces are not final.
Doc comments missing